Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GetTestOrDie to MustGetTest #2098

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Rename GetTestOrDie to MustGetTest #2098

merged 1 commit into from
Nov 9, 2023

Conversation

michi-covalent
Copy link
Contributor

Fixes: 89c7ff0 ("connectivity: Add GetTestOrDie()")

Ref: #2096 (review)

@michi-covalent
Rename GetTestOrDie to MustGetTest
69e6ab9 
Fixes: 89c7ff0 ("connectivity: Add GetTestOrDie()")

Ref: #2096 (review)

Signed-off-by: Michi Mutsuzaki <[email protected]>
@michi-covalent michi-covalent requested a review from a team as a code owner November 9, 2023 15:49
@michi-covalent michi-covalent requested a review from nebril November 9, 2023 15:49
@michi-covalent michi-covalent mentioned this pull request Nov 9, 2023
Merged
tklauser
tklauser approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

@tklauser tklauser merged commit 55a8d60 into main Nov 9, 2023
19 checks passed
@tklauser tklauser deleted the pr/michi/rename branch November 9, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@nebril nebril Awaiting requested review from nebril nebril was automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michi-covalent @tklauser